Re: [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c

[KOSAKI Motohiro]

(2011/05/16 7:20), Stephen Wilson wrote:
> Moving show_numa_map() from mempolicy.c to task_mmu.c solves several
> issues.
> 
>    - Having the show() operation "miles away" from the corresponding
>      seq_file iteration operations is a maintenance burden.
> 
>    - The need to export ad hoc info like struct proc_maps_private is
>      eliminated.
> 
>    - The implementation of show_numa_map() can be improved in a simple
>      manner by cooperating with the other seq_file operations (start,
>      stop, etc) -- something that would be messy to do without this
>      change.
> 
> Signed-off-by: Stephen Wilson<wilsons@xxxxxxxx>
> Cc: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
> Cc: Hugh Dickins<hughd@xxxxxxxxxx>
> Cc: David Rientjes<rientjes@xxxxxxxxxx>
> Cc: Lee Schermerhorn<lee.schermerhorn@xxxxxx>
> Cc: Alexey Dobriyan<adobriyan@xxxxxxxxx>
> Cc: Christoph Lameter<cl@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/