Re: [PATCH] module: Use binary search in lookup_symbol()

[Dirk Behme]

On 17.05.2011 05:52, Rusty Russell wrote:
> On Mon, 16 May 2011 22:23:40 +0200, Alessio Igor Bogani<abogani@xxxxxxxxxx>  wrote:
> > This work was supported by a hardware donation from the CE Linux Forum.
> >
> > Signed-off-by: Alessio Igor Bogani<abogani@xxxxxxxxxx>
> > ---
> >   kernel/module.c |    6 ++----
> >   1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/kernel/module.c b/kernel/module.c
> > index 6a34337..54355c5 100644
> > --- a/kernel/module.c
> > +++ b/kernel/module.c
> > @@ -2055,10 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name,
> >   	const struct kernel_symbol *stop)
> >   {
> >   	const struct kernel_symbol *ks = start;
> > -	for (; ks<  stop; ks++)
> > -		if (strcmp(ks->name, name) == 0)
> > -			return ks;
> > -	return NULL;
> > +	return bsearch(name, start, stop - start,
> > +			sizeof(struct kernel_symbol), cmp_name);
> >   }
> >
> >   static int is_exported(const char *name, unsigned long value,
>
> Applied.

Sorry, but where have you applied it?

With the version above we should get a warning

kernel/module.c: In function 'lookup_symbol':
kernel/module.c:1809: warning: unused variable 'ks'

?

Best regards

Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/