Re: [PATCH v2 3/3] PM / DEVFREQ: add sysfs interface (including user tickling)

[MyungJoo Ham]

On Thu, May 12, 2011 at 7:55 AM, Greg KH <gregkh@xxxxxxx> wrote:
> On Wed, May 11, 2011 at 04:58:43PM +0900, MyungJoo Ham wrote:
>> 1. System-wide sysfs interface
>> - tickle_all ÂR: number of tickle_all execution
>> Â Â Â Â Â Â Â W: tickle all devfreq devices
>> - min_interval    ÂR: devfreq monitoring base interval in ms
>> - monitoring ÂR: shows whether devfreq monitoring is active or
>> Â not.
>>
>> 2. Device specific sysfs interface
>> - tickle   ÂR: number of tickle execution for the device
>> Â Â Â Â Â Â Â W: tickle the device
>
> Any sysfs file change/addition/removal needs to have a
> Documentation/ABI/ entry as well. ÂPlease add that to this patch instead
> of burying it in the changelog entry, where no one will be able to find
> it in the future.
>
> thanks,
>
> greg k-h
>

Sure, I'll add Documentation/ABI/testing/* entries.

However, would it be appropriate for "1. System-wide sysfs interface"
to be in "sysfs-class-power" and for "2. Device specific sysfs
interface" to be in "sysfs-devices-devfreq"?

System-wide sysfs interface is in /sys/class/power/devfreq/* and
Device specific sysfs interface is in /sys/...DEVICE.../devfreq/* .

Thank you.


- MyungJoo
-- 
MyungJoo Ham (íëì), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/