Re: [PATCH v5 03/19] ARM: LPAE: Use unsigned long for__phys_to_virt and __virt_to_phys

[Catalin Marinas]

On Sun, 2011-05-08 at 22:44 +0100, Russell King - ARM Linux wrote:
> On Sun, May 08, 2011 at 01:51:22PM +0100, Catalin Marinas wrote:
> > The !CONFIG_ARM_PATCH_PHYS_VIRT case uses macros for __phys_to_virt and
> > __virt_to_phys but does not use any type casting. This causes issues
> 
> It might be a good idea to include the compiler warning message in the
> commit log, so that the 'issues' being addressed are readily known.

Here's the new log:

    ARM: LPAE: Use unsigned long for __phys_to_virt and __virt_to_phys
    
    The !CONFIG_ARM_PATCH_PHYS_VIRT case uses macros for __phys_to_virt and
    __virt_to_phys but does not use any type casting. This causes compiler
    warnings with LPAE where the phys_addr_t and dma_addr_t are 64-bit:
    
      CC      arch/arm/mm/dma-mapping.o
    In file included from /work/Linux/linux-marc/include/linux/dma-mapping.h:93:0,
                     from /work/Linux/linux-marc/arch/arm/mm/dma-mapping.c:19:
    /work/Linux/linux-marc/arch/arm/include/asm/dma-mapping.h: In function 'dma_to_virt':
    /work/Linux/linux-marc/arch/arm/include/asm/dma-mapping.h:35:9: warning:
            cast to pointer from integer of different size
    
    Note that these macros are only valid for lowmem physical addresses
    where the range is within 32-bit address range.
    
    Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>

-- 
Catalin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/