Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

[RafaÅ MiÅecki]

2011/5/6 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
> 2011/5/6 Arnd Bergmann <arnd@xxxxxxxx>:
>>> +const char *bcma_device_name(u16 coreid)
>>> +{
>>> + Â Â switch (coreid) {
>>> + Â Â case BCMA_CORE_OOB_ROUTER:
>>> + Â Â Â Â Â Â return "OOB Router";
>>> + Â Â case BCMA_CORE_INVALID:
>>> + Â Â Â Â Â Â return "Invalid";
>>> + Â Â case BCMA_CORE_CHIPCOMMON:
>>> + Â Â Â Â Â Â return "ChipCommon";
>>> + Â Â case BCMA_CORE_ILINE20:
>>> + Â Â Â Â Â Â return "ILine 20";
>>
>> It's better to make that a data structure than a switch() statement,
>> both from readability and efficiency aspects.
>
> Well, maybe. We call it only once, at init time. In any case we're
> still waiting for Broadcom to clarify which cores are really used for
> BCMA.

Arnd: did you have a look at defines at all?

Most of the defines have values in range 0x800 â 0x837. Converting
this to array means loosing 0x800 u16 entries. We can not use 0x800
offset, because there are also some defined between 0x000 and 0x800:
#define BCMA_CORE_OOB_ROUTER           0x367   /* Out of band */
#define BCMA_CORE_INVALID              0x700

Oh and there is still:
#define BCMA_CORE_DEFAULT              0xFFF
we could want to include. Then we would loose additional (0xFFF -
0x837) u16 entries in array.

I'll just leave this huge "case". As I said, it's called only once on
initialization time. For standard PCI cards there are usually 3-5
cores, for embedded systems this number can be bigger, but still is
limited with 16 for 1 bus:
#define BCMA_MAX_NR_CORES              16

-- 
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/