Re: [PATCH] perf tools: Makefile: Use gcc to determine ARCH

From: Ingo Molnar
Date: Sat May 07 2011 - 05:40:25 EST



* Lin Ming <ming.m.lin@xxxxxxxxx> wrote:

> The original Makefile uses "uname -m" to determine ARCH.
> This causes problem on x86 when compile perf tool on 32 bit userspace
> with a 64 bit kernel.
>
> bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
> bench/../../../arch/x86/lib/memcpy_64.S:28: Error: bad register name `%rdi'
>
> This is because "uname -m" returns x86_64 and memcpy_64.S is included in 32 bit build.
>
> Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>

this changelog is missing an important line:

Reported-by: Riccardo Magliocchetti <riccardo.magliocchetti@xxxxxxxxx>

I've added it.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/