[PATCH 00/11] rtc: Fix rtc breakage found by commit f44f7f96a20

From: John Stultz
Date: Fri May 06 2011 - 21:21:52 EST


Since commit f44f7f96a20 ("RTC: Initialize kernel state from RTC")
landed in 2.6.39-rc1, we've seen a few reports of boot time hangs
cropping up. It ends up that the problematic rtc drivers were
calling rtc_device_register before it finished initializing critical
data for the rtc driver to function.

Wolfram Sang noticed that this issue was actually more common then
just the few reports seen, and motivated me to do a complete audit
of all the RTC drivers to ensure they were not being registered
before any critical drvdata was initialized.

This patchset is the result of that audit, along with earlier
noted fixes from Wolfram's and Uwe.

Thanks again to Wolfram and Uwe for the patches and helping make
these issues a priority.

CC: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CC: rtc-linux@xxxxxxxxxxxxxxxx


John Stultz (7):
rtc: ds1286: Initialize drvdata before registering device
rtc: m41t80: Initialize clientdata before registering device
rtc: max8925: Initialize drvdata before registering device
rtc: max8998: Initialize drvdata before registering device
rtc: msm6242: Initialize drvdata before registering device
rtc: pcap: Initialize drvdata before registering device
rtc: rp5c01: Initialize drvdata before registering device

Uwe Kleine-KÃnig (1):
rtc: mc13xxx: Don't call rtc_device_register while holding lock

Wolfram Sang (3):
rtc: mxc: Initialize drvdata before registering device
rtc: davinci: Initialize drvdata before registering device
rtc: ep93xx: Initialize drvdata before registering device

drivers/rtc/rtc-davinci.c | 5 +++--
drivers/rtc/rtc-ds1286.c | 2 +-
drivers/rtc/rtc-ep93xx.c | 5 ++---
drivers/rtc/rtc-m41t80.c | 5 +++--
drivers/rtc/rtc-max8925.c | 5 +++--
drivers/rtc/rtc-max8998.c | 5 +++--
drivers/rtc/rtc-mc13xxx.c | 8 ++++++--
drivers/rtc/rtc-msm6242.c | 3 ++-
drivers/rtc/rtc-mxc.c | 19 +++++++++++--------
drivers/rtc/rtc-pcap.c | 4 +++-
drivers/rtc/rtc-rp5c01.c | 5 +++--
11 files changed, 40 insertions(+), 26 deletions(-)

--
1.7.3.2.146.gca209

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/