Re: [RFC PATCH v3 1/6] of: Allow scripts/dtc/libfdt to be used fromkernel code

[David Daney]

On 05/06/2011 03:56 AM, Michal Marek wrote:
> On 5.5.2011 19:02, David Daney wrote:
> > --- /dev/null
> > +++ b/drivers/of/libfdt/Makefile
> > @@ -0,0 +1,8 @@
> > +ccflags-y := -include linux/libfdt_env.h
> > -I$(src)/../../../scripts/dtc/libfdt
> > +
> > +obj-y = fdt.o fdt_wip.o fdt_ro.o
> > +
> > +
> > +$(obj)/%.o: $(src)/../../../scripts/dtc/libfdt/%.c FORCE
> > + $(call cmd,force_checksrc)
> > + $(call if_changed_rule,cc_o_c)
>
> It's just three source files, so you could use three one-line wrappers
> that #include ../../../scripts/dtc/libfdt/<file>.c instead of copying
> the %.c -> %.o rule here.

Good idea, that does seem cleaner.

I will adjust the patch.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/