Re: [PATCH] Add $KERNELRELEASE to firmware install path

From: David Woodhouse
Date: Fri May 06 2011 - 06:18:41 EST


On Fri, 2011-05-06 at 12:15 +0200, Michal Marek wrote:
>
> On 5.5.2011 19:39, Arun Sharma wrote:
> > Useful in the presence of multiple kernels with different
> > firmware versions.
>
> The changelog should also include the udev version that is able to find
> the firmware there (v127, August 2008). FWIW, SUSE has been using this
> patch since about that time, but we forgot to push this :-|. Anyway

No, this is fundamentally broken. Do not do it.

The firmware lives in /lib/firmware, not in /lib/firmware/$KERNELVERSION

There is *no* reason to move it there. If a given firmware file changes
in an incompatible way, it needs to have had a new filename *anyway*
(think of it like a new soname on a shared library).

And we shouldn't be updating the legacy firmware images in the kernel
*anyway*; nobody should be using those any more. They were *purely* for
backward compatibility. Everyone should be shipping the
linux-firmware.git images instead.

--
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/