Re: [PATCH] cpumask: alloc_cpumask_var() use NUMA_NO_NODE

From: Andrew Morton
Date: Thu May 05 2011 - 15:46:10 EST


On Thu, 28 Apr 2011 23:17:15 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> NUMA_NO_NODE and numa_node_id() are different meanings. NUMA_NO_NODE
> is obviously recomended fallback.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> ---
> lib/cpumask.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/cpumask.c b/lib/cpumask.c
> index 4f6425d..af3e581 100644
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -131,7 +131,7 @@ EXPORT_SYMBOL(zalloc_cpumask_var_node);
> */
> bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
> {
> - return alloc_cpumask_var_node(mask, flags, numa_node_id());
> + return alloc_cpumask_var_node(mask, flags, NUMA_NO_NODE);
> }
> EXPORT_SYMBOL(alloc_cpumask_var);
>

So effectively this will replace numa_node_id() with numa_mem_id(),
yes? What runtime effects might this have?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/