Re: [PATCH 1/2 v2] fs: add SEEK_HOLE and SEEK_DATA flags

[Marco Stornelli]

Il 04/05/2011 19:58, Josef Bacik ha scritto:
> +		if (offset>= i_size_read(inode)) {
> +			mutex_unlock(&inode->i_mutex);
> +			return -ENXIO;
> +		}
> +		offset = i_size_read(inode);
> +		break;

I can add that generic_file_llseek_unlocked means *unlocked* so you 
shouldn't unlock any mutex but only return a value. The current version, 
in case of SEEK_END uses directly i_size indeed, so maybe I'm missing 
something.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/