Re: [PATCH 3/3] writeback: avoid extra sync work at enqueue time

[Wu Fengguang]

On Thu, May 05, 2011 at 08:42:37PM +0800, Christoph Hellwig wrote:
> On Thu, May 05, 2011 at 02:41:22PM +0200, Christoph Hellwig wrote:
> > On Thu, May 05, 2011 at 08:27:32PM +0800, Wu Fengguang wrote:
> > > -	wbc.wb_start = jiffies; /* livelock avoidance */
> > > +	oldest_jif = jiffies;
> > > +	wbc.older_than_this = &oldest_jif;
> > 
> > Can't you kill the oldest_jif variable now?
> 
> Err, -ENOCOFFEE.  You could only kill it if you implement Jan's suggestion
> of not making older_than_this a pointer..

Yes. And that won't be a straightforward code refactor. It will have
very small side effects, so we'd better kill it in a standalone patch.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/