Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table

[Greg Ungerer]

Hi Arnd,

On 05/05/11 16:24, Arnd Bergmann wrote:
> On Wednesday 04 May 2011, Geert Uytterhoeven wrote:
> > Impact for nommu:
> >    - Store table in .rodata instead of .text,
> >    - Let kernel/sys_ni.c handle the stubbing of MMU-only syscalls,
> >    - Implement sys_mremap and sys_nfsservct,
> >    - Remove unused padding at the end of the table.
> >
> > Impact for mmu:
> >    - Store table in .rodata instead of .data.
> >
> > Signed-off-by: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>
>
> What happened to the mmap syscall? IIRC, nommu is pointing to
> a different symbol (sys_mmap_pgoff/sys_mmap2).

Thats taken care of in this patch with:

> diff --git a/arch/m68k/kernel/syscalltable.S 
b/arch/m68k/kernel/syscalltable.S
> index 9b8393d..0284192 100644
> --- a/arch/m68k/kernel/syscalltable.S
> +++ b/arch/m68k/kernel/syscalltable.S
> @@ -1,6 +1,4 @@
[snip]
> +#ifndef CONFIG_MMU
> +#define sys_mmap2		sys_mmap_pgoff
> +#endif
> +

Regards
Greg


> Did you check the macros in unistd to see if they match the
> actual table? I guess it would be a good time to comment out
> the ones that are not implemented in either of the two ABIs.
>
> Otherwise, this patch looks good to me.
>
> 	Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/