Re: [PATCH] Allocate memory cgroup structures in local nodes
From: Andi Kleen
Date: Wed May 04 2011 - 16:04:38 EST
Before that's considered, the order of the arguments to
alloc_pages_exact_node() needs to be fixed.
Good point. I'll send another one.
This is really misleading BTW. Grumble. Maybe it would be actually
better to
change the prototype too.
The vmalloc_node() calls ensure that the nid is actually set in
N_HIGH_MEMORY and fails otherwise (we don't fallback to using vmalloc()),
so it looks like the failures for alloc_pages_exact_node() and
vmalloc_node() would be different? Why do we want to fallback for one and
not the other?
The right order would be to try everything (alloc_pages + vmalloc)
to get it node local, before trying everything else. Right now that's
not how it's done.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/