Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies tohyperv Kconfig

[Randy Dunlap]

On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:

> On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > >
> > > The vmbus driver dependes on ACPI and PCI subsystems. Change 
> > > Kconfig to reflect this.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > > ---
> > >  drivers/staging/hv/Kconfig |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > index 76f0756..5e0c9f6 100644
> > > --- a/drivers/staging/hv/Kconfig
> > > +++ b/drivers/staging/hv/Kconfig
> > > @@ -1,6 +1,6 @@
> > >  config HYPERV
> > >  	tristate "Microsoft Hyper-V client drivers"
> > > -	depends on X86 && m
> > > +	depends on X86 && ACPI && PCI && m
> > >  	default n
> > >  	help
> > > 	  Select this option to run Linux as a Hyper-V client operating
> > 
> > ACPI itself depends on PCI.
> 
> Still?  I thought that got removed a while ago.

Still.  Len has written in the past that technically there is no such
dependency, but in reality there is, for now at least.  IIRC.


> > It also depends on IA64 || X86.  Will the vmbus driver work with IA64?
> 
> No.
> 
> > If so the depends on could just be:
> > 
> > 	depends on ACPI && m
> 
> No, see above for the IA64 reason.
> 
> > Also, default n is redudant since n is the default anyway.
> 
> True, but it doesn't hurt either :)


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/