Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

[Geert Uytterhoeven]

On Wed, May 4, 2011 at 17:00, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
>> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
>> index e1ada31..779efdc 100644
>> --- a/arch/m68k/atari/atakeyb.c
>> +++ b/arch/m68k/atari/atakeyb.c
>> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
>> Â Â Â kb_state.len = 0;
>>
>> Â Â Â error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
>> - Â Â Â Â Â Â Â Â Â Â Â Â IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
>> + Â Â Â Â Â Â Â Â Â Â Â Â IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",
>
> The name is not a path, but an enumeration, so the slash should probably
> be changed to a comma instead.

I thought about that, but comma (albeit followed by a space) is also used to
separate multiple interrupt handlers for shared interrupts.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/