Re: [PATCHv3 0/7] gpio: extend basic_mmio_gpio for differentcontrollers

[Alan Cox]

> OK, so here's what I've got so far (patches attached).  I've updated the 
> basic_mmio_gpio library with your initial lkml patch and updated it to 
> allow bgpio_chip to be embedded in another structure.  I've also 
> attempted to convert over the bt8xx and langwell drivers but they're a 
> little rough around the edges in places (and untested as I don't have 
> the hardware).

Looking at the Langwell driver you replace 130 lines of code that do the
job, with 126 lines of code that do setup for a whole extra module which
makes it bigger and slower as well as much harder to maintain.

That sounds to me like for Langwell at least it is not worth doing
because all you've done is added complexity, indirection and overhead. So
NAK the Langwell one.

The bt8xx looks a nice example of one of the cases where it will help
however.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/