Re: msleep() an load average

From: Clemens Ladisch
Date: Wed May 04 2011 - 09:45:15 EST


Eibach, Dirk wrote:
> while(1) msleep_interruptible(1000);
>
> Is this code really any better?

You should handle signals, probably by blocking any that you're not
interested in, and exiting on any fatal one.

Anyway, polling is bad; this code forces the CPU to wake up once
per second. What is your thread _actually_ waiting for?
(I guess it has more code than what you wrote?)


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/