Re: [RFC PATCH] tracing: Don't call wakeup() when committing the event

[Vaibhav Nagarnaik]

On Tue, May 3, 2011 at 4:35 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> On Tue, May 03, 2011 at 04:27:22PM -0700, Vaibhav Nagarnaik wrote:
>> How about this? Check if the waitqueue is active and if true, operate on the
>> trace_wait queue.
>>
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 06f4458..e03ee24 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -353,7 +353,7 @@ void trace_wake_up(void)
>>  {
>>       int cpu;
>>
>> -     if (trace_flags & TRACE_ITER_BLOCK)
>> +     if (trace_flags & TRACE_ITER_BLOCK || !waitqueue_active(&trace_wait))
>>               return;
>>       /*
>>        * The runqueue_is_locked() can fail, but this is the best we
>>
>
> Hehe, seems it should work :)
>
> Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>
Thanks for reviewing the change. I have sent an updated patch with a better
commit message and your Ack.

Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/