Re: [PATCH 2/2] leds: Add ASIC3 LED support

[Paul Parsons]

Hi Philipp,

--- On Tue, 3/5/11, Philipp Zabel <philipp.zabel@xxxxxxxxx> wrote:

> About this, see the other patch I sent. This should work
> with the GPIOs
> configured as outputs.
See my response on the other thread.

> I'd just use DIV_ROUND_CLOSEST((ms)*1024, 32000) here.
Will change.

> Could be moved into struct resource definitions in
> asic3.c.
> Get to them with platform_get_resource() in
> asic3_led_probe().
> After calculating the bus shift from the resource size, you
> have
> everything you need to get rid of the
> asic3_write_register() export.
I understand, but my feeling is that implementing a more generic mechanism will add complexity for little obvious gain. If the LED driver ever needs to be more generic then this can be revisited.

> Why not just return mfd_cell_disable(pdev);?
It wasn't always at the end of the function as it is now! Will change.

Regards,
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/