Re: [PATCH 1/2] mfd: Add ASIC3 LED support

[Paul Parsons]

Hi Philipp,

--- On Tue, 3/5/11, Philipp Zabel <philipp.zabel@xxxxxxxxx> wrote:

> I'd like to avoid this export. Could you inform the cell
> driver of
> mapping and bus shift via io resources as it is done in
> ds1wm?
> Same for this one.

The LED registers are already mapped by the mfd driver, and the functions to access them are already provided. My feeling is that replicating all of that seems a high price to pay to avoid exporting a couple of functions.

> Ok for now, I guess. But it's unrelated to led support. And
> once we have
> a common struct clk and can use clk_enable in the led
> driver, there's
> going to be error checking anyway...
Yes, that's a separate patch if at all.

> As Samuel pointed out, better use .platform_data and
> .platform_size here
> right away.
Will do.

> Separate patch?
Separate patch.

> As I said, not convinced about that one. I'll follow up
> with a patch to
> test on top of yours.
OK.

Regards,
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/