Re: [PATCH 3/5] TPS65911: Add new irq definitions

[Mark Brown]

On Tue, May 03, 2011 at 11:18:56AM -0500, Jorge Eduardo Candelaria wrote:

> +	if (tps65910_chip_id(tps65910) == TPS65911) {
> +		tps65910->read(tps65910, TPS65910_INT_STS3, 1, &reg);
> +		irq_sts |= reg << 16;
> +	}

switch statements feel better for future proofing - if your hardware
guys do another design derived from this base you'll need to add another
case in here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/