Re: [RFC patch 29/32] trace event asoc remove semicolons

From: Steven Rostedt
Date: Tue May 03 2011 - 10:34:54 EST


On Tue, 2011-05-03 at 15:24 +0100, Mark Brown wrote:
> On Tue, May 03, 2011 at 03:14:37PM +0100, Mark Brown wrote:

> OK, now I see patch 1 I understand why you're doing this. It should
> still be at least called out in the patch description if not actually
> split out into a separate patch (which would be ideal) - one of the
> things that really stands out in reviews is unrelated changes.

I actually think there should have been two different patch sets. One
for the semi colon clean up, and the other to do the work for arrays.
The semi colon clean up is non-controversial as it is just a clean up
that does not affect the current code at all.

But the added array preparation is not needed until we do the array
work, which deserves its own patch set.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/