Re: [PATCH 2/4] perf: Add persistent event facilities

From: Ingo Molnar
Date: Tue May 03 2011 - 04:23:25 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> > we could move the other perf_events.c facilities there as well, and maybe
> > split up the file a bit, it's 7.5 KLOC now which is a bit excessive.
>
> Right, so I left perf_event.c as a whole on purpose (only renamed) because it
> makes more sense IMHO for someone who actually wrote it to split it in
> logical parts (^hint hint^). I mean, I could do it too but it'll take me much
> more time :).

Well you are now writing new events code as well so spending that time might be
a good investment in terms of getting persistent.c right as well.

Could you send a Git pull request against perf/core that does the obvious file
movement and renaming? We can do that first step straight away and get the ball
rolling.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/