Re: [PATCH 1/4] drivers: create a pinmux subsystem

[Ben Nizette]

On 03/05/2011, at 5:16 AM, Linus Walleij wrote:

> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> This creates a subsystem for handling of pinmux devices. These are
> devices that enable and disable groups of pins on primarily PGA and
> BGA type of chip packages and common in embedded systems.
> 
> This is being done to depopulate the arch/arm/* directory of such
> custom drivers and try to abstract the infrastructure they all
> need. See the Documentation/pinmux.txt file that is part of this
> patch for more details.

Haven't reviewed the actual code but at an interface level it seems
sane.  It'd be nice to actually implement a driver for some nutbars SoC
and make sure it all shakes out but in the first instance I can't see
any problems.

Leaving it orthogonal to gpio is a great move conceptually and if it does
need to be tied back to the gpio_request() interface later then, well,
we'll cross that bridge when we come to it.

Thanks for your work in this area, looking good.

	--Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/