Re: [Xen-devel] Re: [PATCH] Two patches fixing regression introducedby 'x86-64, mm: Put early page table high'

From: H. Peter Anvin
Date: Mon May 02 2011 - 15:59:57 EST


On 05/02/2011 12:34 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, May 02, 2011 at 11:33:16AM -0700, H. Peter Anvin wrote:
>> On 05/02/2011 11:08 AM, Konrad Rzeszutek Wilk wrote:
>>>>
>>>> My inclination would be to apply your workaround -- are there any
>>>> adverse effects to doing that?
>>>
>>> There is a bootup slowdown (not noticeable). That is because we call the
>>> 'memblock_find_range' function on every PTE table creation (only during
>>> bootup of course).
>>>
>>> Testing wise, on the machines on which the regression occurred, with these two
>>> patches the regression disappears - so that is a good sign. I am testing
>>> it on some more today to assure myself I am not missing anything.
>>>
>>
>> OK, sounds like a plan then. I like it because it doesn't affect the
>> native kernel.
>
> <laughs> I figured :-)
>
> Moving forward I really want to get rid of this wart.
>
> Not sure if it is possible, but I was thinking it would be nice to get
> you, Yinghai, Jeremy, Stefano all in one place (phone or web-conference thing)
> to sketch out some ideas and hammer something out.
>
> What days would work best?

First things first... are you pushing the workaround (you can add my
Acked-by:) or should I?

Second... I don't know what physical locations and/or time zones every
one is in, which is probably the first thing.

Third, I will be travelling a lot over the next two weeks, plus we are
getting close to merge window time, so it might be hard to schedule
before the merge window. Are you looking at trying to push something
for .40? If so, you probably should have an implementation in mind
already. If not, I suggest we aim for after the merge window is over or
at least quieted down.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/