Re: [PATCH V3 2/8] Add a new zerocopy device flag

From: Michael S. Tsirkin
Date: Mon May 02 2011 - 15:53:28 EST


On Mon, May 02, 2011 at 11:47:08AM -0700, Shirley Ma wrote:
> On Mon, 2011-05-02 at 13:42 +0300, Michael S. Tsirkin wrote:
> > This comment should specify what exactly is the promise the
> > device makes by setting this flag. Specifically, the
> > condition is that no skb fragments are used
> > after the uinfo callback has been called.
> >
> > The way it's implemented, it probably means the device
> > should not use any of skb_clone, expand head etc.
>
> Agree. Or maybe force a copy when device uses skb_clone, expand
> head ...?
>
> Thanks
> Shirley

Copy from userspace upfront without locking is probably cheaper?

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/