Re: [PATCH v5 4/8] arm/dt: probe for platforms via the device tree

[Tony Lindgren]

* Grant Likely <grant.likely@xxxxxxxxxxxx> [110502 18:31]:
> On Mon, May 2, 2011 at 9:15 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > * Grant Likely <grant.likely@xxxxxxxxxxxx> [110429 00:13]:
> >> +
> >> +/**
> >> + * setup_machine_fdt - Machine setup when an dtb was passed to the kernel
> >> + * @dt_phys: physical address of dt blob
> >> + *
> >> + * If a dtb was passed to the kernel in r2, then use it to choose the
> >> + * correct machine_desc and to setup the system.
> >> + */
> >> +struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> >> +{
> > ...
> >
> >> +
> >> + Â Â /* Retrieve various information from the /chosen node */
> >> + Â Â of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
> >
> > Just to make sure we're considering properly what this change means..
> >
> > Does this patch require using CONFIG_CMDLINE_FORCE for older bootloaders
> > with the device tree append patch?
> 
> With the current patch?  Yes, but there is a follow-on patch that was
> posted a while ago[1] that will copy ATAG data into the device tree in
> the bootloader.  I've not been pushing to include that change since it
> adds a lot of code to the wrapper and I'm not sure how deeply we want
> to support that use case.  Basically I want to have a better idea what
> the supported use cases are before pushing something like that.

OK. Maybe that could be made simpler if we only copy the cmdline?

The cmdline is something that bootloaders typically allow to configure,
while the other ATAGs are static and should be in the .dts file.
 
> Adding a default command line to the .dts file instead of using
> CONFIG_CMDLINE_FORCE also works.

But that requires carrying extra patches for something that should
be user configured.. So not so nice for distros.

Tony
 
> [1] http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-March/004652.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/