Re: [PATCH] Input: h3600_ts_input - bugfix forrequest_irq()/free_irq() parameters

From: Dmitry Torokhov
Date: Sun May 01 2011 - 12:59:31 EST


On Mon, May 02, 2011 at 12:23:43AM +0800, Axel Lin wrote:
> Hi Dmitry,
>
> 2011/4/29 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> > On Wed, Apr 13, 2011 at 08:37:11PM +0800, Axel Lin wrote:
> >> The dev field of h3600_dev is a pointer, thus use ts->dev instead of &ts->dev
> >> as the dev_id argument while calling request_irq()/free_irq().
> >
> > dev_id does not need to have specific type, it is just a cookie so as
> > long as it's value is unique we are OK. &ts->dev works as well as
> > ts->dev.
>
> Then you might want to apply below patch:
> http://www.spinics.net/lists/linux-input/msg15042.html
>
> My original intension was to fix the irq driver data mismatch.
>

Ah, I see. Then I'll apply it but with teh above as commit message.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/