Re: [PATCH] x86, NUMA: Fix empty memblk detection innuma_cleanup_meminfo()

From: Tejun Heo
Date: Sun May 01 2011 - 06:21:09 EST


Hello,

On Sat, Apr 30, 2011 at 05:43:22PM -0700, Yinghai Lu wrote:
> this one works too
> but print out is some strange
> on 512g system got:
>
> NUMA: Initialized distance table, cnt=8
> NUMA: Node 0 [0,a0000) + [100000,80000000) -> [0,80000000)
> NUMA: Node 0 [0,80000000) + [100000000,1080000000) -> [0,1000000000)
>
>
> first patch on 512g system got
> NUMA: Node 0 [0,a0000) + [100000,80000000) -> [0,80000000)
> NUMA: Node 0 [0,80000000) + [100000000,1000000000) -> [0,1000000000)
>
> still thinking first one is more clean.

Yeah, I don't object to the change (it's easier to understand too) but
it should be a separate patch because it's unrelated change to the fix
itself. If you don't mind sending the splitting part separately, I'll
put it on top of the patchset.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/