Re: [PATCH] s390: convert old cpumask API into new one

From: KOSAKI Motohiro
Date: Thu Apr 28 2011 - 11:45:55 EST


> > @@ -1016,21 +1016,21 @@ int __ref smp_rescan_cpus(void)
> >
> > Â Â Â Âget_online_cpus();
> > Â Â Â Âmutex_lock(&smp_cpu_state_mutex);
> > - Â Â Â newcpus = cpu_present_map;
> > + Â Â Â cpumask_copy(&newcpus, cpu_present_mask);
> > Â Â Â Ârc = __smp_rescan_cpus();
> > Â Â Â Âif (rc)
> > Â Â Â Â Â Â Â Âgoto out;
> > - Â Â Â cpus_andnot(newcpus, cpu_present_map, newcpus);
> > - Â Â Â for_each_cpu_mask(cpu, newcpus) {
> > + Â Â Â cpumask_andnot(&newcpus, cpu_present_mask, &newcpus);
> > + Â Â Â for_each_cpu(cpu,&newcpus) {
> please, could you add a space between cpu and ,&newcpus?

Thank you for finding.