Re: [PATCH] linux/string.h: Introduce streq macro.

From: Al Viro
Date: Wed Apr 27 2011 - 12:46:46 EST


On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote:
> This macro is arguably more readable than its variants:
> - !strcmp(a, b)
> - strcmp(a, b) == 0

Strongly NACKed. As far as I'm concerned, it's in the same shitbucket as
bcopy(3), bzero(3) et.al. Use idiomatic C; extensions of that kind are
*bad*, since new developers have to learn them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/