Re: [PATCH 7/8] staging/mei: AMT Watchdog

From: Greg KH
Date: Wed Apr 27 2011 - 11:18:21 EST


On Wed, Apr 27, 2011 at 03:53:01PM +0200, Arnd Bergmann wrote:
> On Wednesday 27 April 2011, Oren Weil wrote:
> >
> > code that open connection and invoke
> > heartbeats to the AMT Watchdog client/feature, if exists
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > Signed-off-by: Itzhak Tzeel-Krupp <itzhak.tzeel-krupp@xxxxxxxxx>
> > Signed-off-by: Oren Weil <oren.jer.weil@xxxxxxxxx>
>
> I still think this should be a regular watchdog driver using
> the drivers/watchdog user interface.

I agree, Oren, if you are going to insist on doing things this way, you
had better describe _why_ you are ignoring the existing kernel
interfaces provided.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/