[RFC][PATCH 4/7] smack: fix label check in smack_kernel_act_as()

From: Roberto Sassu
Date: Wed Apr 27 2011 - 08:36:50 EST


The function smack_kernel_act_as() must return -EINVAL if the label
returned by smack_from_secid() is equal to 'smack_known_invalid.smk_known',
which means that no entries in the 'smack_known_list' list matching the
security identifier given are found.

Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxx>
---
security/smack/smack_lsm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index e3c9e54..0e7ed31 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -1415,7 +1415,7 @@ static int smack_kernel_act_as(struct cred *new, u32 secid)
struct task_smack *new_tsp = new->security;
char *smack = smack_from_secid(secid);

- if (smack == NULL)
+ if (smack == smack_known_invalid.smk_known)
return -EINVAL;

new_tsp->smk_task = smack;
--
1.7.4.4

Attachment: smime.p7s
Description: S/MIME cryptographic signature