Re: [PATCH 1/8] staging/mei: PCI device and char driver support.

From: Jiri Slaby
Date: Wed Apr 27 2011 - 08:25:02 EST


On 04/27/2011 12:27 PM, Oren Weil wrote:
> + dev->mem_addr = pci_iomap(pdev, 0, 0);
...
> + iounmap(dev->mem_addr);
...
> + if (dev->mem_addr)
> + iounmap(dev->mem_addr);

Just what I noticed after a quick look: you shall use pci_iounmap for
pci_iomap'ped space.

regards,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/