Re: [PATCH 1/2] memblock: add error return when CONFIG_HAVE_MEMBLOCKis not set

From: Mike Travis
Date: Tue Apr 26 2011 - 13:07:25 EST




Andrew Morton wrote:
On Mon, 25 Apr 2011 13:11:37 -0500
Mike Travis <travis@xxxxxxx> wrote:

Add an error return if CONFIG_HAVE_MEMBLOCK is not set instead
of having to add #ifdef CONFIG_HAVE_MEMBLOCK around blocks of
code calling that function.

Authored-by: Yinghai Lu <yinghai@xxxxxxxxxx>
Signed-off-by: Mike Travis <travis@xxxxxxx>

There is no such thing as "Authored-by:". If this patch was written by
yinghai then it must be tagged as From:him at the top of the changelog
and preferably has his signed-off-by: at the end.

Please clarify?

Yes, you have it correct. I had added the From: line but when I receive
the email, it's removed.

Why not have an "Authored-by"? That would eliminate the sendmail program
from screwing it up?

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/