Re: [PATCH v2 2/7] signal: retarget_shared_pending: considershared/unblocked signals only

From: Tejun Heo
Date: Mon Apr 25 2011 - 06:52:39 EST


On Mon, Apr 18, 2011 at 03:45:01PM +0200, Oleg Nesterov wrote:
> -static void retarget_shared_pending(struct task_struct *tsk)
> +static void retarget_shared_pending(struct task_struct *tsk, sigset_t *set)

Hmm... @set? Maybe a name which refelcts its purpose, say @target or
@consider would be better? Also, it would be really great to have
docbook function comment describing the parameter.

Other than that,

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/