Re: [PATCH] kconfig: Avoid buffer underrun in choice input

From: Ben Hutchings
Date: Sun Apr 24 2011 - 00:02:16 EST


On Sat, 2011-04-23 at 20:04 +0200, Sam Ravnborg wrote:
> On Sat, Apr 23, 2011 at 06:42:56PM +0100, Ben Hutchings wrote:
> > commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default
> > value for choice input') fixed some cases where kconfig would select
> > the wrong option from a choice with a single valid option and thus
> > enter an infinite loop.
> >
> > However, this broke the test for user input of the form 'N?', because
> > when kconfig selects the single valid option the input is zero-length
> > and the test will read the byte before the input buffer. If this
> > happens to contain '?' (as it will in a mips build on Debian unstable
> > today) then kconfig again enters an infinite loop.
> >
> > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxx [2.6.17+]
> > ---
> > Roman has failed to respond to this after 5 weeks and one reminder, so
> > please take it directly.
>
> No-one has heard from Roman Zippel in several years.
> I have suggested Michal Marek to take over the maintainer
> role - as he in practice is the kconfig maintainer.

Can someone please update MAINTAINERS then? What is the point of it if
people don't update it for years?

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part