Re: [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c touse Linux style comparisons

[H. Peter Anvin]

On 04/22/2011 10:40 AM, John Reiser wrote:
> On 04/22/2011 09:13 AM, Steven Rostedt wrote:
>> Although, I have no idea why you choose the 0 < var, that totally
>> confuses me. It does not play any role in assignments. What bug is that
>> preventing? When I want to know if a variable is greater than zero, I
>> don't show it as zero less than the var.
> 
> Using ">" can be confused visually with "->", and I want to reduce those
> chances.  I also prefer a style that is prefix oriented, and with constants
> on the left.  I mentally combine the left constant and the infix operator
> into a special case prefix operator.  This speeds my parsing because it
> reduces stack depth and enables faster scanning.  This is particularly
> helpful when the constant is narrow and the other operand is wider.
> 

I think you will find you're significantly in the minority when it comes
to that preference.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/