Re: [PATCH 1/2] fs: add SEEK_HOLE and SEEK_DATA flags

[Matthew Wilcox]

On Thu, Apr 21, 2011 at 04:45:54PM -0400, Theodore Tso wrote:
> 
> On Apr 21, 2011, at 3:42 PM, Josef Bacik wrote:
> 
> > +	case SEEK_DATA:
> > +	case SEEK_HOLE:
> > +		return -EINVAL;
> > 	}
> 
> Maybe we should be returning EOPNOTSUPP?

That's definitely wrong ... -ENOSYS might be better!

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/