Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues

From: Karthigan Srinivasan
Date: Thu Apr 21 2011 - 12:08:26 EST


> You are introducing trailing whitespace.
>
> > return AE_BAD_DATA;
> > - }
> > +
> ^^^^^^^^^^^^^
> For every pair of braces you clean away, you're adding
> two new coding style issues.

Nicolas - appreciate your feedback and apologize for the error. I have
corrected these issues. Re-submitting patch below with corrections.

Best Regards,
Karthigan Srinivasan.


Fixed brace and comment coding style issues is code.

Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@xxxxxx>
---
drivers/acpi/utils.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..76eaac2 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,8 @@ acpi_extract_package(union acpi_object *package,

union acpi_object *element = &(package->package.elements[i]);

- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }

switch (element->type) {

@@ -185,9 +184,8 @@ acpi_extract_package(union acpi_object *package,
u8 **pointer = NULL;
union acpi_object *element = &(package->package.elements[i]);

- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }

switch (element->type) {

@@ -303,9 +301,8 @@ acpi_evaluate_reference(acpi_handle handle,
u32 i = 0;


- if (!list) {
+ if (!list)
return AE_BAD_PARAMETER;
- }

/* Evaluate object. */

@@ -337,9 +334,9 @@ acpi_evaluate_reference(acpi_handle handle,
goto end;
}

- if (package->package.count > ACPI_MAX_HANDLES) {
+ if (package->package.count > ACPI_MAX_HANDLES)
return AE_NO_MEMORY;
- }
+
list->count = package->package.count;

/* Extract package data. */
@@ -373,7 +370,7 @@ acpi_evaluate_reference(acpi_handle handle,
end:
if (ACPI_FAILURE(status)) {
list->count = 0;
- //kfree(list->handles);
+ /* kfree(list->handles); */
}

kfree(buffer.pointer);
--
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/