Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clearcpuc->active_mask on overflow

From: Don Zickus
Date: Thu Apr 21 2011 - 08:53:57 EST


On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
> It's not enough to simply disable event on overflow the cpuc->active_mask
> should be cleared as well otherwise counter may stall in "active" even
> in real being already disabled (which potentially may lead to the situation
> that user may not use this counter further).

I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
the box

Acked-by: Don Zickus <dzickus@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/