Re: [PATCH] HID: add support for PenMount dual-touch panel

From: Henrik Rydberg
Date: Wed Apr 20 2011 - 06:06:30 EST


> > Benjamin: Since field->index == 0 is in use, it seems the driver could
> > execute event emission wrongly under some circumstances (when
> > last_field_index == 0). Is that related to the reason for the quirk in
> > this patch?
>
> In fact, I have a second patch just on top of this one. It has been
> tested by Ryan with PenMount devices.

Great, and good timing. :-)

> I was waiting for Penmount to be included first as it does not impact
> any other drivers.

I would prefer the opposite order, since it is cleaner and means one
less device to test for the major change.

>
> I inline the code here, but my gmail client will destroy tabs (so I
> attached it too)....
>
> Can you test it against 3M?

I will test it against 3M and egalax. Thanks!

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/