Re: [PATCH v2 0/2] Store and load PCI device saved state across functionresets

From: Avi Kivity
Date: Wed Apr 20 2011 - 04:19:35 EST


On 04/19/2011 11:12 PM, Alex Williamson wrote:
v1 -> v2:
Make the pointer passed around less opaque for type safety.

Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because
the KVM module attempts to do a pci_save_state() before assigning
the device to a VM, expecting that the saved state will remain
valid until we release the device. This is in conflict with our
need to reset devices using PCI sysfs during a VM reset to
quiesce the device. Any calls to pci_reset_function() will
overwrite the device saved stated prior to reset, and reload and
invalidate the state after. KVM then ends up trying to restore
the state, but it's already invalid, so the device ends up with
reset values.

This series adds a mechanism to pull the saved state off the
struct pci_dev and reload it later. Thanks,

Based on the sizes of the patches, this should go in via the pci tree.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/