[PATCH 6/6] NFS: return -EAGAIN when skipped commit in nfs_commit_unstable_pages()

From: Wu Fengguang
Date: Mon Apr 18 2011 - 23:10:28 EST


It's probably not sane to return success while redirtying the inode at
the same time in ->write_inode().

CC: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
---
fs/nfs/write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next.orig/fs/nfs/write.c 2011-04-19 10:18:16.000000000 +0800
+++ linux-next/fs/nfs/write.c 2011-04-19 10:18:32.000000000 +0800
@@ -1519,7 +1519,7 @@ static int nfs_commit_unstable_pages(str
{
struct nfs_inode *nfsi = NFS_I(inode);
int flags = FLUSH_SYNC;
- int ret = 0;
+ int ret = -EAGAIN;

if (wbc->sync_mode == WB_SYNC_NONE) {
/* Don't commit yet if this is a non-blocking flush and there


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/