Re: [PATCH v2] uio/pdrv_genirq: Add OF support

From: Michal Simek
Date: Mon Apr 18 2011 - 04:33:21 EST


Hi Wolfram,

Wolfram Sang wrote:
Hi Michal,

On Thu, Apr 14, 2011 at 11:41:46AM +0200, Michal Simek wrote:
Support OF support. "generic-uio" compatible property is used.

This description is not true anymore. Please also add a short paragrpah how it
is intended to be used now.

ok.


Signed-off-by: Michal Simek <monstr@xxxxxxxxx>

+ uioinfo->version = "dt";

Minor nit: "devicetree" is probably more descriptive.

no problem to change it


+
+ /* Multiple IRQs are not supported */
+ if (pdev->num_resources > 1) {
+ struct resource *r = &pdev->resource[1];

Are you sure the irq-ressource is always [1]? (Similar question for the
if()-block above). Try platform_get_irq().

I wasn't aware about platform_get_irq. You are right.

What "if()-block above" are you talking about?
Above is kzalloc uioinfo allocation.
I am going to send v3 that's why please comment this there.


+#ifdef CONFIG_OF
+/*
+ * Empty match table for of_platform binding

While it probably doesn't make change to put every supported device in
upstream, it still deosn't technically have to be empty. So, mabye drop this
comment and add something like "/* empty for now */" to the table?

ok, done.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/