Re: [PATCH 0/1] mm: make read-only accessors take const pointerparameters

From: Michal Nazarewicz
Date: Fri Apr 15 2011 - 12:12:42 EST


On Fri, 15 Apr 2011 17:59:16 +0200, Phil Carmody wrote:
I'm just glad this wasn't an insta-nack, as I am quite a fan of
consts, and hopefully something can be worked out.

I feel you man. Unfortunately, I think that const, since it's an
after-thought, is not very usable in C.

For instance, as you've pointed in your patch, the "_ro" suffix
is sort of dumb, but without it compound_head would have to take
const and return non-const (like strchr() does) which is kinda
stupid as well.

What's more, because of lack of encapsulation, âconst struct pageâ
only means that the object is const but thighs it points to aren't.
As such, const does not really play that well with structs anyway.

const is, in my opinion, one of those things C++ actually got
right (or close to right).

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/