Re: [PATCH] make sparse happy with gfp.h

From: KOSAKI Motohiro
Date: Fri Apr 15 2011 - 01:33:30 EST


Hello,

> On Fri, 2011-04-15 at 12:14 +0900, KOSAKI Motohiro wrote:
> > > #ifdef CONFIG_DEBUG_VM
> > > - BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > + BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> > > #endif
> > > - }
> > > return z;
> >
> > Why don't you use VM_BUG_ON?
>
> I was just trying to make a minimal patch that did a single thing.
>
> Feel free to submit another one that does that. I'm sure there are a
> couple more places that could use similar love.

I posted another approach patches a second ago. Could you please see it?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/