Re: BUILD_BUG_ON() breaks sparse gfp_t checks

[Dave Hansen]

On Thu, 2011-04-14 at 13:22 -0700, Andrew Morton wrote:
> The kernel calls gfp_zone() with a constant arg in very few places. 
> This?
> 
> --- a/include/linux/gfp.h~a
> +++ a/include/linux/gfp.h
> @@ -249,14 +249,9 @@ static inline enum zone_type gfp_zone(gf
>  
>         z = (GFP_ZONE_TABLE >> (bit * ZONES_SHIFT)) &
>                                          ((1 << ZONES_SHIFT) - 1);
> -
> -       if (__builtin_constant_p(bit))
> -               BUILD_BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> -       else {
>  #ifdef CONFIG_DEBUG_VM
> -               BUG_ON((GFP_ZONE_BAD >> bit) & 1);
> +       BUG_ON((GFP_ZONE_BAD >> bit) & 1);
>  #endif
> -       }
>         return z;
>  } 

That definitely makes sparse happier.  I hope the folks on cc will chime
in if they wanted something special at build time.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/