Re: [PATCH -v3] x86, MCE: Drop the default decoding notifier

[Prarit Bhargava]

On 04/14/2011 03:02 PM, Borislav Petkov wrote:
> On Thu, Apr 14, 2011 at 11:49:08AM -0400, Prarit Bhargava wrote:
>   
>>> And we don't want to fix that - we want to fix the case with the
>>> occasional CE MCEs which get detected in the polling path but none of
>>> their MCA regs get dumped for decoding so the decoding hint there is
>>> out of place. And we fixed that at least partially so that it doesn't
>>> flood the logs. If you're not fine with the default ratelimit of 10 msgs
>>> per 5 seconds we can always raise the ratelimit but tweaking an almost
>>> hypothetical case is just not worth it.
>>>
>>>       
>> Okay -- I'm good then.
>>     
> Ok, injecting MCEs with this patch looks like this. Nevermind the
> decoded MCEs, I simply uncommented the "if (ret != NOTIFY_DONE)" line
> so that I can see the rate limiting. So we still have them there, this
> is the default setting of 10 calls per 5 secs, we might want to dial it
> down in the output. After the 10th MCE, it doesn't appear anymore.
>
> Hmm...
>
> Prarit, you said you have a machine which spits a lot of CECCs on boot,
> does the final version help there, did you have a chance to run it?
>   

Yup -- it looked good and did what I expected it to do ... I didn't save
the output though :(

P.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/